Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add more documentation to crypto_core. #2648

Merged
merged 1 commit into from Feb 6, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 4, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Feb 4, 2024
@iphydf iphydf marked this pull request as ready for review February 4, 2024 23:22
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bdaaae) 73.64% compared to head (d55fc85) 73.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
- Coverage   73.64%   73.61%   -0.03%     
==========================================
  Files         148      148              
  Lines       30406    30404       -2     
==========================================
- Hits        22392    22383       -9     
- Misses       8014     8021       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the crypto-core-doc branch 2 times, most recently from 9a99a66 to 5f10e32 Compare February 4, 2024 23:50
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked some of the defines you removed and was surprised to learn how some of them were defined in multiple places, sometimes even obviously redundant: ENC_PUBLIC_KEY_SIZE was defined in both toxcore/crypto_core.c and toxcore/crypto_core.h. What? How?

@toktok-releaser toktok-releaser merged commit d55fc85 into TokTok:master Feb 6, 2024
60 checks passed
@iphydf iphydf deleted the crypto-core-doc branch February 6, 2024 23:30
zoff99 added a commit to zoff99/c-toxcore that referenced this pull request Apr 4, 2024
…a02cba2756

this was included upstream in this PR: TokTok#2648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants