docs: Add more documentation to crypto_core.#2648
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2648 +/- ##
==========================================
- Coverage 73.64% 73.61% -0.03%
==========================================
Files 148 148
Lines 30406 30404 -2
==========================================
- Hits 22392 22383 -9
- Misses 8014 8021 +7 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
crypto-core-doc
branch
2 times, most recently
from
9a99a66 to
5f10e32
Compare
nurupo
approved these changes
Feb 5, 2024
Member
There was a problem hiding this comment.
Checked some of the defines you removed and was surprised to learn how some of them were defined in multiple places, sometimes even obviously redundant: ENC_PUBLIC_KEY_SIZE was defined in both toxcore/crypto_core.c and toxcore/crypto_core.h. What? How?
iphydf
force-pushed
the
crypto-core-doc
branch
from
5f10e32 to
d55fc85
Compare
zoff99
added a commit
to zoff99/c-toxcore
that referenced
this pull request
Apr 4, 2024
…a02cba2756 this was included upstream in this PR: TokTok#2648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is