Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Tox_Options struct as deprecated. #285

Merged
merged 1 commit into from Nov 21, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 20, 2016

We will remove it in v0.1.


This change is Reviewable

@iphydf iphydf added this to the v0.0.5 milestone Nov 20, 2016
@GrayHatter
Copy link

:lgtm:

per IRC

<iphy> and apidsl doesn't understand __attribute__
<grayhatter> yeah, that's what I figured
<grayhatter> apidsl is pretty limiting
<iphy> that's half the point of apidsl

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Nov 20, 2016

:lgtm_strong:


Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@GrayHatter
Copy link

needs formatting

:lgtm_strong:


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


CMakeLists.txt, line 84 at r2 (raw file):

  add_flag("-Wno-conversion")
  add_flag("-Wno-covered-switch-default")
  add_flag("-Wno-documentation-deprecated-sync")

I don't like this, but I guess we have no choice...


Comments from Reviewable

@GrayHatter
Copy link

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

We will remove it in v0.1.
@iphydf iphydf assigned nurupo and GrayHatter and unassigned GrayHatter Nov 21, 2016
@iphydf iphydf merged commit 75a33d2 into TokTok:master Nov 21, 2016
@iphydf iphydf deleted the deprecate-struct branch November 21, 2016 00:27
@iphydf iphydf changed the title Mark Tox_Options struct as deprecated. Mark Tox_Options struct as deprecated. Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants