Revert "Portability fixes" #395
Conversation
This reverts commit f346907.
|
Reviewed 27 of 27 files at r1. Comments from Reviewable |
| # Set standard version for compiler. | ||
| add_cflag("-std=gnu99") | ||
| add_cxxflag("-std=c++98") | ||
|
|
There was a problem hiding this comment.
this looks incorrect to me. You only define the C standard if warnings are enabled?
There was a problem hiding this comment.
Yes. By default, gcc uses gnu89, which is sufficient for us at the moment (soon it won't be). @Zer0-One will hopefully make the original PR again which reverts this revert.
There was a problem hiding this comment.
Just curious, why are cxxflags set in a C-only library?
There was a problem hiding this comment.
We also compile the code as C++ to make sure it's C++ compatible. Reasons:
- Additional C++-only tooling becomes available (static analysers).
- A few checks performed by C++ compilers (enum compatibility, void pointer casts) are useful for us.
|
@endoffile78 Would be nice if the PR mention why the commit was reverted. If I remember correctly from the IRC discussions (which not everyone going over PRs follows closely), it's because that commit broke toxcore on OS X? |
|
@nurupo correct |
This reverts commit f346907.
Reverted because some of the changes in f346907 caused toxcore to not compile on OSX.
This change is