Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check if compiler supports C99 #414

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Conversation

jin-eld
Copy link

@jin-eld jin-eld commented Jan 10, 2017

c-tocxocre will start using C99 code, so check if the compiler supports
it and abort in configure with an error if it does not.

closes #413


This change is Reviewable

c-tocxocre will start using C99 code, so check if the compiler supports
it and abort in configure with an error if it does not.

closes TokTok#413
@jin-eld
Copy link
Author

jin-eld commented Jan 10, 2017

@robinlinden currently I am explicitly checking for C99, it's also possible to check if the compiler supports "standard ISO C", which at this time happens to be C99, so it's more a future question if we want to enable the latest standard ISO C automatically or if we stick with C99 and move forward only when needed.

@GrayHatter
Copy link

:lgtm:

https://travis-ci.org/TokTok/c-toxcore/jobs/190539792#L860-L861


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@robinlinden
Copy link
Member

@jin-eld I think explicitly checking for C99 is better than checking if the compiler supports the latest standard ISO C.

@iphydf
Copy link
Member

iphydf commented Jan 10, 2017

Does this also set the -std=c99 flag?


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Jan 10, 2017

AC_PROG_CC_C99
Ok, found that it does.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@iphydf iphydf merged commit 2d75073 into TokTok:master Jan 10, 2017
@nurupo
Copy link
Member

nurupo commented Jan 13, 2017

:lgtm_strong:


Comments from Reviewable

@iphydf iphydf modified the milestone: v0.1.5 Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support C compilation with -std=c99 in autotools
5 participants