Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out the actual test code from conference_test. #975

Merged
merged 1 commit into from
Jul 7, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 7, 2018

Also, renamed simple_conference_test to conference_simple_test so it's
sorted together with the other conference tests.

Next step is to use run_auto_test.h for the conference test.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 7, 2018
Also, renamed simple_conference_test to conference_simple_test so it's
sorted together with the other conference tests.

Next step is to use run_auto_test.h for the conference test.
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@iphydf iphydf merged commit 3c1025d into TokTok:master Jul 7, 2018
@iphydf iphydf deleted the conference-test branch July 7, 2018 16:01
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants