Factor out time keeping code into its own module: mono_time.c. #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
unix-time
branch
13 times, most recently
from
b606ed0
to
9477765
Compare
|
diff --git a/toxcore/Messenger.c b/toxcore/Messenger.c
@@ -1763,8 +1764,8 @@ static int handle_filecontrol(Messenger *m,
int32_t friendnumber, uint8_t receiv
if (position >= ft->size) {
LOGGER_DEBUG(m->log,
- "file control (friend %d, file %d): seek position %lld exceeds file size %lld",
- friendnumber, filenumber, (unsigned long long)position, (unsigned long long)ft->size);
+ "file control (friend %d, file %d): seek position %ld exceeds file size %ld",
+ friendnumber, filenumber, (unsigned long)position, (unsigned long)ft->size);
return -1;
}
Why these casts from uint64_t to unsigned long?
|
|
|
These are not used in a thread-safe way, but it opens the path towards per-tox-instance time keeping and removal of some unsafe global state.
It turns out, `unix_time` is also monotonic, and is used as such, so I've renamed the new functions to `mono_time_*`. 2018-07-08: ``` 00:01 <@irungentoo> the idea used to be that the unix_time() function could go backward in time but I think I might have started using it like if it could not after I changed it so that it would never go back in time ```
|
test <img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out,
unix_timeis also monotonic, and is used as such, so I'verenamed the new functions to
mono_time_*.2018-07-08:
This change is