Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Travis-CI FreeBSD build #986

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

nurupo
Copy link
Member

@nurupo nurupo commented Jul 8, 2018

I went ahead and updated FreeBSD to use 11.2 image because the 11.1 was giving

WARNING: FreeBSD 11.1-RELEASE is approaching its End-of-Life date.
It is strongly recommended that you upgrade to a newer
release within the next 2 months.

message. I had to reduce the 8 mirrors down to 2, because apparently only 2 of them have 11.2 release. They must be syncing once per month or rarer. We could add more mirrors as more of them get the release.


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iphydf iphydf added this to the v0.2.x milestone Jul 8, 2018
@nurupo nurupo force-pushed the simplify-travs-freebsd branch 9 times, most recently from d467d85 to 9662a98 Compare July 10, 2018 15:14
@nurupo nurupo changed the title [WIP] Simplify Travis-CI FreeBSD build Simplify Travis-CI FreeBSD build Jul 10, 2018
@nurupo
Copy link
Member Author

nurupo commented Jul 10, 2018

@nurupo nurupo requested a review from iphydf July 10, 2018 15:15
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained (waiting on @iphydf)


.travis/cmake-freebsd-stage2, line 18 at r1 (raw file):


  # Extract the cached image
  tar -Sxzvf $IMAGE_NAME.tgz

Put variables into double quotes to avoid potential double parsing of values with spaces in them.

@nurupo
Copy link
Member Author

nurupo commented Jul 14, 2018

Hm, the build suddenly started failing, it wasn't doing that before. poweroff as root disconnects us from ssh but for some reason the VM still keeps running until the build times out, it doesn't "poweroff" properly.

@nurupo
Copy link
Member Author

nurupo commented Jul 14, 2018

Sending poweroff over ssh doesn't work but sending it to the qemu tty does. Go figure what the issue is. I would have tried to reproduce the ssh poweroff issue on my local machine, but I have 4GiB of disk space left which won't be enough. Sending poweroff to tty works and I don't see any downsides to it, do let's just roll with that.

Copy link
Member Author

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 9 files at r1, 4 of 4 files at r2.
Reviewable status: 0 of 1 LGTMs obtained


.travis/cmake-freebsd-stage2, line 18 at r1 (raw file):

Previously, iphydf wrote…

Put variables into double quotes to avoid potential double parsing of values with spaces in them.

Done.

Copy link
Member Author

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


.travis/cmake-freebsd-stage1, line 0 at r2 (raw file):

File appears to be binary.

Good job reviewable.

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


.travis/cmake-freebsd-stage1, line at r2 (raw file):

Previously, nurupo wrote…

File appears to be binary.

Good job reviewable.

It's because there is a literal ESC byte in this script instead of an escape sequence for it.

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Copy link
Member Author

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained


.travis/cmake-freebsd-stage1, line at r2 (raw file):

Previously, iphydf wrote…

It's because there is a literal ESC byte in this script instead of an escape sequence for it.

That was my guess.

@nurupo
Copy link
Member Author

nurupo commented Jul 15, 2018

Rebased on master.

@iphydf iphydf merged commit c0b4cd1 into TokTok:master Jul 15, 2018
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants