Use named function types for callbacks in net_crypto. #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudden6
requested changes
Jul 8, 2018
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
toxcore/net_crypto.c, line 3006 at r1 (raw file):
if (conn->status == CRYPTO_CONN_ESTABLISHED) { // TODO(irungentoo): add a timeout here? continue;
This piece of code looks very suspicious, add a comment that this is only to satisfy the coding style?
iphydf
force-pushed
the
nc-cb-types
branch
2 times, most recently
from
d3d04a3
to
509daa7
Compare
iphydf
commented
Jul 8, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
toxcore/net_crypto.c, line 3006 at r1 (raw file):
Previously, sudden6 wrote…
This piece of code looks very suspicious, add a comment that this is only to satisfy the coding style?
Is this clear enough?
iphydf
force-pushed
the
nc-cb-types
branch
2 times, most recently
from
bb8395d
to
3b96652
Compare
Also: * compound statements (blocks, e.g. in if/else) must be non-empty. Comments don't count. * `=` is not allowed in subexpressions. We treat it as statement-only. * `++i` is preferred over `i++` in statements. * `Type_Names` are camelsnake-case.
sudden6
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 LGTMs obtained
toxcore/net_crypto.c, line 3006 at r1 (raw file):
Previously, iphydf wrote…
Is this clear enough?
ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Comments don't count.
=is not allowed in subexpressions. We treat it as statement-only.++iis preferred overi++in statements.Type_Namesare camelsnake-case.This change is