WIP: Add messenger state plugin system. #992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
messenger-state-plugin
branch
12 times, most recently
from
e43a3e7
to
770dda1
Compare
hugbubby
approved these changes
Jul 15, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
|
@hugbubby this is highly WIP (Work In Progress) and needs proper design first. I've just put it here as an example of some thought I had. I wouldn't want to merge this as is. Generally, WIP PRs are not ready for review. |
iphydf
force-pushed
the
messenger-state-plugin
branch
4 times, most recently
from
ae58e4a
to
c8b2223
Compare
iphydf
force-pushed
the
messenger-state-plugin
branch
2 times, most recently
from
64f4444
to
85aaff1
Compare
iphydf
force-pushed
the
messenger-state-plugin
branch
from
85aaff1
to
45c0a6c
Compare
This is for modules like groups to hook into to have their own state management in the `tox_savedata` format.
iphydf
force-pushed
the
messenger-state-plugin
branch
from
45c0a6c
to
8c8abbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for modules like groups to hook into to have their own state
management in the
tox_savedataformat.This change is