Separate msgpack types from serialization details [2/2] #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kondrachkov <SX91@protonmail.com>
|
|
SX91
added
the
enhancement
iphydf
reviewed
Apr 12, 2017
data-msgpack.cabal
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: data-msgpack | |||
| version: 0.0.9 | |||
| version: 0.1.0 | |||
There was a problem hiding this comment.
Why is this a minor version bump? Why not 0.0.10?
|
Please enable the checkbox "Allow edits from maintainers." on the bottom right. |
|
@iphydf It's already checked. And I've fixed version to be a patch bump. |
|
Any idea why appveyor is failing? |
|
Review status: 0 of 14 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Comments from Reviewable |
|
@SX91 you have push access to this repo, so once it's ready, feel free to merge. |
|
So, what about actually merging this? |
|
Reviewed 13 of 14 files at r1, 1 of 1 files at r5. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of TokTok/hs-msgpack-types#1
This change is