Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out cimple into a separate package. #53

Merged
merged 1 commit into from Apr 19, 2020
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Apr 10, 2020

Tokstyle now depends on that separate cimple package.


This change is Reviewable

@iphydf iphydf force-pushed the cimple branch 2 times, most recently from 3234228 to bf55cad Compare April 16, 2020 01:26
@iphydf iphydf requested review from a team and nurupo and removed request for a team April 16, 2020 23:16
Tokstyle now depends on that separate cimple package.

Also, added an analysis to check for `(void)` in empty parameter lists.
Tokstyle requires this, but Cimple now supports empty parameter lists
because of Apidsl. This analysis puts back the enforcement of that rule.
@iphydf iphydf merged commit 743c7e0 into TokTok:master Apr 19, 2020
@iphydf iphydf deleted the cimple branch April 19, 2020 21:10
@iphydf iphydf temporarily deployed to tokstyle April 19, 2020 21:10 Inactive
@iphydf iphydf added this to the v0.0.6 milestone May 1, 2020
@iphydf iphydf modified the milestones: v0.0.6, v0.0.7 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants