Fix build #71
Merged
Fix build #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvladyslav
reviewed
Sep 26, 2019
| @@ -175,6 +175,11 @@ target_link_libraries(${PROJECT_NAME} | |||
| ${PROTOBUF_LIBRARIES} | |||
| ) | |||
|
|
|||
| target_compile_options(${PROJECT_NAME} | |||
| PRIVATE | |||
| -Wno-error=unusable-partial-specialization | |||
There was a problem hiding this comment.
IMHO, this is a bad idea. I'd prefer to fix the code instead of concealing problems.
There was a problem hiding this comment.
In order to not conceal the problem, I excluded the new warning from Werror, but left the warning in so it's very obviously still there: https://travis-ci.org/TokTok/jvm-toxcore-c/builds/588156956#L802 (The difference between -Wno-unusable-partial-specialization and -Wno-error=unusable-partial-specialization.)
If you want to try to fix the warning you're very welcome to, because I had a quick look and won't be able to without reading up on C++ templates.
iphydf
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70
This change is