Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for navigation items #22

Closed
MaxDesiatov opened this issue Jan 31, 2019 · 0 comments · Fixed by #27
Closed

Add support for navigation items #22

MaxDesiatov opened this issue Jan 31, 2019 · 0 comments · Fixed by #27
Labels
API design API design and prototyping is needed

Comments

@MaxDesiatov
Copy link
Collaborator

MaxDesiatov commented Jan 31, 2019 •
edited

This is needed for ListView demo modal in Example project
@MaxDesiatov MaxDesiatov mentioned this issue Feb 4, 2019
Merged
@MaxDesiatov MaxDesiatov added the API design API design and prototyping is needed label Feb 4, 2019
@MaxDesiatov MaxDesiatov changed the title Add navigation items and NavigationBar Add support for navigation items Feb 9, 2019
MaxDesiatov added a commit that referenced this issue Feb 11, 2019
@MaxDesiatov
Add NavigationItem host component (#27)
e413b06 
Resolves #22

* Add StackControllerItem host component
* Move {Stack,Navigation}Presenter, related changes
* Update StandardComponents doc with new name
* Fix styling after view controller behavior change
* Remove style from StackView.Props.init
* Add `viewDidLoad` comment to UIViewComponent
* Fix tests not compiling
* Implement basic UIHostComponent for NavigationItem
* Implement prefersLargeTitles, test item titles
* Remove unused public func isSubtypeOf<T, U, V, W>
* Remove unused NavigationItemBox, fix formatting
* Remove missing file from the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API design API design and prototyping is needed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NavigationItem host component TokamakUI/Tokamak
1 participant
@MaxDesiatov