Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable async/await in DOM Fiber renderer #516

Merged
merged 1 commit into from Oct 2, 2022
Merged

Enable async/await in DOM Fiber renderer #516

merged 1 commit into from Oct 2, 2022

Conversation

ahti
Copy link
Contributor

@ahti ahti commented Sep 18, 2022

I noticed that Tasks weren't running when using the Fiber renderer. I'm not sure this is the appropriate place, but the normal DOM renderer calls installGlobalExecutor in it's init, so I just mirrored that.

@carson-katri carson-katri added bug Something isn't working Fiber Changes related to the FiberReconciler or a FiberRenderer labels Sep 25, 2022
carson-katri
carson-katri approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@carson-katri carson-katri merged commit 56822c9 into TokamakUI:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carson-katri carson-katri carson-katri approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Fiber Changes related to the FiberReconciler or a FiberRenderer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahti @carson-katri