Adding more about solc options, trying to figure out how to make Ethe…

…rScan to verify solc 0.4.14.

crowdsales/allocated-token-sale-example.yml

@@ -21,7 +21,12 @@ kovan:
     #
     #     solc --version
     #
-    solc_version: 0.4.14+commit.c2215d46
+    # Note that for EtherScan you need to add letter "v" at the front of the version
+    #
+    # Note: You need to have correct optmization settings for the compiler
+    # in populus.json that matches what EtherScan is expecting.
+    #
+    solc_version: v0.4.14+commit.c2215d46
 
     contracts:
         # This is the address of the multisig wallet where the paymnts eventually land

crowdsales/example.yml

@@ -10,6 +10,21 @@ testnet:
     # This is a semi automatic process using a Firefox browser.
     verify_on_etherscan: yes
 
+    # For available versions see
+    # https://etherscan.io/address/0xa8659f5af01796b39e0dfb3323acc00d8fe97ea2#code
+    # Click Verify and Publish
+    # See values in Compiler drop down.
+    # You can also get the local compiler version with:
+    #
+    #     solc --version
+    #
+    # Note that for EtherScan you need to add letter "v" at the front of the version
+    #
+    # Note: You need to have correct optmization settings for the compiler
+    # in populus.json that matches what EtherScan is expecting.
+    #
+    solc_version: v0.4.14+commit.c2215d46
+
     #
     # Contracts section defines different smart contracts that
     # are required to run the ICO.

crowdsales/unit-test.yml

@@ -9,6 +9,9 @@ unit_test:
     # This is a semi automatic process using a Firefox browser.
     verify_on_etherscan: no
 
+    # Not used in unit tests
+    solc_version: v0.4.14+commit.c2215d46
+
     #
     # Contracts section defines different smart contracts that
     # are required to run the ICO.

ico/deploy.py

@@ -145,7 +145,8 @@ def deploy_crowdsale(project: Project, chain, source_definitions: dict, deploy_a
                 constructor_args=runtime_data["contracts"][name]["constructor_args"],
                 libraries=runtime_data["contracts"][name]["libraries"],
                 browser_driver=browser_driver,
-                compiler=solc_version)
+                compiler=solc_version,
+                optimization=False)
             runtime_data["contracts"][name]["etherscan_link"] = get_etherscan_link(chain_name, runtime_data["contracts"][name]["address"])
 
             # Write out our expanded contract

ico/etherscan.py

@@ -92,6 +92,7 @@ def verify_contract(project: Project, chain_name: str, address: str, contract_na
 
         print("Contract verification failed. Check the browser for details.")
         print("Make sure solc_version in your YAML file matches solc --version output.")
+        print("Make sure solc optimization settings are the same as what EtherScan thinks.")
         input("Press enter to continue")
 
     return src

populus.json

@@ -172,7 +172,7 @@
         "settings": {
           "stdin": {
             "optimizer": {
-              "enabled": true,
+              "enabled": false,
               "runs": 500
             },
             "outputSelection": {