Modify IA storage slot on proxies #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxies were using the storage slot from the ERC-1822 proxy pattern, but instead of using it to store direct implementation we used it to store the address of the Implementation Authority.
The fact of using this storage slot created issues with the explorers such as polygonscan which believed we used ERC-1822 and displayed the ABI of the Implementation Authority instead of the ABI of the implementation contracts.
This PR proposes a new storage slot
0x821f3e4d3d679f19eacc940c87acf846ea6eae24a63058ea750304437a62aafcwhich is the result ofkeccak256("ERC-3643.proxy.beacon")