Trex 121 recovery function modify #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joachim-Lebrun
requested changes
Jun 20, 2024
| @@ -268,8 +268,11 @@ contract IdentityRegistry is IIdentityRegistry, AgentRoleUpgradeable, IRStorage | |||
| IIdentity _identity, | |||
| uint16 _country | |||
| ) public override onlyAgent { | |||
| _tokenIdentityStorage.addIdentityToStorage(_userAddress, _identity, _country); | |||
| emit IdentityRegistered(_userAddress, _identity); | |||
| IIdentity identity = _tokenIdentityStorage.storedIdentity(_userAddress); | |||
There was a problem hiding this comment.
you shouldn't change the registerIdentity method for updating the recovery process
There was a problem hiding this comment.
if a wallet is already registered there is a function update to change the OID linked to it, add function shouldn't be used for that
| @@ -40,20 +40,6 @@ describe('Token - Recovery', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('when new wallet is not authorized on the identity', () => { | |||
There was a problem hiding this comment.
We need to test the case in which 2 tokens that are linked to the same IRS are doing the recovery as it is what the bug was.
There was a problem hiding this comment.
in old implementation it should have worked on the first token and then failed on the second because the Identity Registry storage was already modified by the first recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tokeny.atlassian.net/browse/TREX-121