Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

enable to change data label for TimeStackedBarChart #1770

Merged
merged 2 commits into from Mar 19, 2020
Merged

enable to change data label for TimeStackedBarChart #1770

merged 2 commits into from Mar 19, 2020

Conversation

mmfiber
Copy link
Contributor

@mmfiber mmfiber commented Mar 18, 2020 •
edited

👏 解決する issue / Resolved Issues

⛏ 変更内容 / Details of Changes

  • enable to add more than 2 data to TimeStackedBarChart.vue
  • enable to change data labels

📸 スクリーンショット / Screenshots

@PichuChen
Copy link
Contributor

I think we can use items as default source?

@mmfiber
Copy link
Contributor Author

mmfiber commented Mar 18, 2020 •
edited

@PichuChen

I think we can use items as default source?

I don't think so because items and data-labels are slightly different.

items: [this.$t('都内発生（疑い例・接触者調査）'), this.$t('その他（チャーター便・クルーズ船）')]
data-lables: [this.$t('都内'), this.$t('その他')]

@PichuChen
Copy link
Contributor

@PichuChen

I think we can use items as default source?

I don't think so because items and data-labels are slightly different.

items: [this.$t('都内発生（疑い例・接触者調査）'), this.$t('その他（チャーター便・クルーズ船）')]
data-lables: [this.$t('都内'), this.$t('その他')]

I think you are right

@MaySoMusician MaySoMusician added the i18n 多言語関連の Issue や Pull Request label Mar 18, 2020
@kaizumaki
Copy link
Collaborator

I think this is a great implementation! Can I review it?

@kaizumaki kaizumaki marked this pull request as ready for review March 19, 2020 00:18
@kaizumaki kaizumaki self-requested a review March 19, 2020 00:20
kaizumaki
kaizumaki approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@kaizumaki kaizumaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's so wonderful!

@kaizumaki kaizumaki added the ready-for-merge コードレビューが終わり、マージができるもの label Mar 19, 2020
@halsk halsk merged commit b460da1 into Tokyo-Metro-Gov:development Mar 19, 2020
MaySoMusician pushed a commit to MaySoMusician/covid19 that referenced this pull request Mar 19, 2020
@halsk @MaySoMusician
Merge pull request Tokyo-Metro-Gov#1770 from mmfiber/feature/issue-17…
b3a1072 
…18-enable-to-change-time-bar-stack-chart-data-labels

enable to change data label for TimeStackedBarChart

(cherry picked from commit b460da1)
halsk added a commit that referenced this pull request Mar 26, 2020
@halsk
Merge pull request #1770 from mmfiber/feature/issue-1718-enable-to-ch…
0970133 
…ange-time-bar-stack-chart-data-labels

enable to change data label for TimeStackedBarChart
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaizumaki kaizumaki kaizumaki approved these changes

Assignees
No one assigned
Labels
i18n 多言語関連の Issue や Pull Request ready-for-merge コードレビューが終わり、マージができるもの
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use :items data for TimeStackedBarChart.vue
5 participants
@mmfiber @PichuChen @kaizumaki @halsk @MaySoMusician