Introduce TimeOut waiter #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
reviewed
Oct 28, 2016
| private $timeOut; | ||
|
|
||
| /** | ||
| * var float |
| */ | ||
| private $secondsEllapsed; | ||
|
|
||
| public function __construct(Waiter $delegateWaiter, $timeOut) |
There was a problem hiding this comment.
Can you add a PhpDoc on the constructor?
| { | ||
| $this->delegateWaiter = $delegateWaiter; | ||
| $this->timeOut = $timeOut; | ||
| $this->secondsEllapsed = 0; |
There was a problem hiding this comment.
0.0 if your secondsEllapsed property is actually float.
There was a problem hiding this comment.
But we definitively should consider to switch the $seconds in Waiter::wait to float also. I currently use 0.5 in my own app. And this is why I managed secondsEllapsed in float
tyx
force-pushed
the
feature/add-time-out-waiter
branch
from
a9aa47a
to
5710cfa
Compare
|
changes done
|
|
Thank you @tyx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if any change should be done to be merged