Fix mypy check error: pandas merge copy param

[shenxiangzhuang]

Fix #104

Checklist

• I have read the CONTRIBUTING document
• I hereby agree to the terms of either individual CLA available at: https://toloka.ai/legal/cla_individual or corporate CLA available at: https://toloka.ai/legal/cla_corporate, whichever is applicable to me, as it pertains to direct contributions to crowd-kit only
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

[dustalov]

Hi, the last time I tried, every type check passed well. Why turning on copying fixes it? It might increase the memory usage as it is performed at each E-step.

[shenxiangzhuang]

Hi, the last time I tried, every type check passed well. Why turning on copying fixes it? It might increase the memory usage as it is performed at each E-step.

The error is from mypy checking process as showed in #104, which come from the latest update of pandas-stubs. And I agree that this change will increase the memory usage, maybe we can just add # type: ignore after this line.

Maybe we can just close this pr and related issue for now and talk about it until we reproduce the ci error in the repo.

[pilot7747]

I'd either add # type: ignore or figure out how to make it pass mypy checks without copying.

[dustalov]

These stubs must have been ahead of time. Let’s add the corresponding type: ignore[call-arg] comment then.

[shenxiangzhuang]

These stubs must have been ahead of time. Let’s add the corresponding type: ignore[call-arg] comment then.

Using # type: ignore[call-arg, unused-ignore] instead to avoid introduce another check error like fellows:

crowdkit/aggregation/classification/glad.py:161: error: Unused "type: ignore" comment  [unused-ignore]
Found 1 error in 1 file (checked 79 source files)
Error: Process completed with exit code 1.

[shenxiangzhuang]

I'd either add # type: ignore or figure out how to make it pass mypy checks without copying.

Hi @pilot7747 , thanks for your reply! I just give a suggestion here and feel free to close this pr without merge if you'd like another solution.

[dustalov]

Wait, if there is unused-ignore error, then the call-arg is not the problem here.

[shenxiangzhuang]

Wait, if there is unused-ignore error, then the call-arg is not the problem here.

https://github.com/Toloka/crowd-kit/pull/105/checks?check_run_id=25642305515
The unused-ignore error only raised in Python3.8, while works well in Python version >=3.9. So I think it's ok here to use # type: ignore[call-arg, unused-ignore] here.

[dustalov]

Ah, I see, thanks! Please remove the space after the comma in the type comment, and we'll merge it immediately.