Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glad labels prior bug #83

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Glad labels prior bug #83

merged 1 commit into from
Oct 3, 2023

Conversation

alexdremov
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.

В случае указания приора на лейблах, падает фит так как self.prior_labels_ не определен

Checklist

  • [ v] I have read the CONTRIBUTING document
  • [v ] I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
  • [x ] My change requires a change to the documentation
  • [x ] I have updated the documentation accordingly
  • [x ] I have added tests to cover my changes
  • [v ] All new and existing tests passed

@dustalov
Copy link
Collaborator

Thank you! We're happy to merge this, but please fix the typing so that the tests pass.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (de3e56a) 93.04% compared to head (547154f) 92.99%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   93.04%   92.99%   -0.05%     
==========================================
  Files          47       47              
  Lines        2012     2013       +1     
==========================================
  Hits         1872     1872              
- Misses        140      141       +1     
Files Coverage Δ
crowdkit/aggregation/classification/glad.py 96.25% <0.00%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdremov
Copy link
Contributor Author

Thank you! We're happy to merge this, but please fix the typing so that the tests pass.

@dustalov I don't understand reasons for tests failure. Could you check them please?

@pilot7747
Copy link
Contributor

@alexdremov Please rebase your branch, we've fixed those test in main

@pilot7747
Copy link
Contributor

Probably we can just merge this PR, I don't think the tests will fail. If it happens, blame me, I'm going to fix them myself.

@pilot7747 pilot7747 merged commit e9b83b5 into Toloka:main Oct 3, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants