GH-36886: [C++] Configure azurite in preparation for testing Azure C++ filesystem
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
Tom-Newton
changed the title
Tom-Newton
changed the title
azurite in preparation for testing Azure C++ filesystem
Tom-Newton
force-pushed
the
tomnewton/configure_azurite/GH-36886
branch
from
8c5060f
to
d1102fc
Compare
|
❌ GitHub issue apache#36886 could not be retrieved. |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
Merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to write tests for apache#18014. azurite is like a fake Azure blob storage so it can be used to write integration tests
What changes are included in this PR?
Extract the
azuriterelated changes from apache#12914 to create a smaller PR that's easier to review. I have made very minimal changes compared to that PR.Currently
azuriteis configured for all the environments whereARROW_AZUREwas enabled by apache#35701. I assume its deliberate that its not enabled yet for windows, alpine, conda, debian or fedora builds.Are these changes tested?
Its tested by there aren't really any good tests in this PR. I used this
azuriteconfig in apache#36835 to make an integration test that uses the Azure C++ SDK. On its own we can't really write tests for thisazuritesetup PR.Are there any user-facing changes?
No