Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse nodes on any terminal status #2

Closed
wants to merge 19 commits into from

Conversation

Tom-Newton
Copy link
Owner

Tracking issue

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch from 3b79086 to 023e204 Compare November 14, 2023 17:02
@Tom-Newton Tom-Newton changed the title ClearSubNodeStatus on failure Collapse nodes on a terminal status Nov 17, 2023
@Tom-Newton Tom-Newton changed the title Collapse nodes on a terminal status Collapse nodes on any terminal status Nov 17, 2023
@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch 2 times, most recently from c15e9a2 to 40c378f Compare November 29, 2023 20:05
@Tom-Newton Tom-Newton changed the base branch from tomnewton/expreiment_with_complete_solution to tomnewton/fix_transient_secret_sync_error_handling November 29, 2023 20:06
@Tom-Newton Tom-Newton force-pushed the tomnewton/fix_transient_secret_sync_error_handling branch 2 times, most recently from cc1a119 to 7a40d98 Compare December 4, 2023 23:41
@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch 2 times, most recently from a4755d9 to 8a2f03a Compare December 13, 2023 14:23
@Tom-Newton Tom-Newton changed the base branch from tomnewton/fix_transient_secret_sync_error_handling to master December 13, 2023 14:31
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch from 3e55c74 to 625ab3d Compare December 13, 2023 18:41
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch from e50ebb8 to 42fb049 Compare December 14, 2023 13:08
… with `clearStateOnAnyTermination=true`

Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch from 5e07651 to 453a69f Compare December 15, 2023 14:51
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton Tom-Newton force-pushed the tomnewton/collapse_sub_nodes_on_failures branch from b812954 to fb9bd90 Compare December 15, 2023 14:56
@Tom-Newton
Copy link
Owner Author

Upstream PR flyteorg#4596

@Tom-Newton Tom-Newton closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant