Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coda min voltage, current precision, formatting #4

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Coda min voltage, current precision, formatting #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f7aff7
Add comments on Coda code. Fix scaling on voltage minimum. Fix low->h…
mdrobnak Dec 15, 2020
f500263
Spacing fixes.
mdrobnak Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
61 changes: 32 additions & 29 deletions VoltBMSV2/VoltBMSV2.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3575,37 +3575,40 @@ void CanSerial() //communication with Victron system over CAN
can.send(0x304, 0, 0, 4, dta);
}
}
if (settings.chargertype == Coda)
{
msg.id = 0x050;
msg.len = 8;
msg.buf[0] = 0x00;
msg.buf[1] = 0xDC;
if ((settings.ChargeVsetpoint * settings.Scells ) > 200)
{
msg.buf[2] = highByte(uint16_t((settings.ChargeVsetpoint * settings.Scells ) * 10));
msg.buf[3] = lowByte(uint16_t((settings.ChargeVsetpoint * settings.Scells ) * 10));
}
else
{
msg.buf[2] = highByte( 400);
msg.buf[3] = lowByte( 400);
}
msg.buf[4] = 0x00;
if ((settings.ChargeVsetpoint * settings.Scells)*chargecurrent < 3300)
{
msg.buf[5] = highByte(uint16_t(((settings.ChargeVsetpoint * settings.Scells) * chargecurrent) / 240));
msg.buf[6] = highByte(uint16_t(((settings.ChargeVsetpoint * settings.Scells) * chargecurrent) / 240));
}
else //15 A AC limit

if (settings.chargertype == Coda)
{
msg.buf[5] = 0x00;
msg.buf[6] = 0x96;
// Data is big endian (MSB, LSB)
// Voltage scaling is value * 10
msg.id = 0x050;
msg.len = 8;
msg.buf[0] = 0x00;
msg.buf[1] = 0xDC;
if ((settings.ChargeVsetpoint * settings.Scells ) > 200)
{
msg.buf[2] = highByte(uint16_t((settings.ChargeVsetpoint * settings.Scells ) * 10));
msg.buf[3] = lowByte(uint16_t((settings.ChargeVsetpoint * settings.Scells ) * 10));
}
else
{
// Voltage minimum is 200V -> 200 * 10 = 2000 -> 0x7D0
msg.buf[2] = 0x07;
msg.buf[3] = 0xD0;
}
msg.buf[4] = 0x00;
if ((settings.ChargeVsetpoint * settings.Scells)*chargecurrent < 3300)
{
msg.buf[5] = highByte(uint16_t(((settings.ChargeVsetpoint * settings.Scells) * chargecurrent) / 240));
msg.buf[6] = lowByte(uint16_t(((settings.ChargeVsetpoint * settings.Scells) * chargecurrent) / 240));
}
else //15 A AC limit
{
msg.buf[5] = 0x00;
msg.buf[6] = 0x96;
}
msg.buf[7] = 0x01; //HV charging
Can0.write(msg);
}
msg.buf[7] = 0x01; //HV charging
Can0.write(msg);
}

}

if (mescycl == 2)
Expand Down