Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self host canvaskit #36

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Self host canvaskit #36

merged 1 commit into from
Oct 4, 2022

Conversation

openpaul
Copy link
Contributor

I noticed that both google fonts as well as canvaskit are not "self-hosted" but fetched from CDNs.

Flutter does not yet provide options to completely self host fonts but has a solution for canvaskit (flutter/flutter#60069 (comment)). As such I propose this change to make use of this functionality.

I hope this is in the spirit of the project as it will increase the "self-hosting" aspect.

Maybe in the future even google fonts can be self hosted, allowing the project to be deployed completely offline.

@TomBursch
Copy link
Owner

Thanks for the contribution, I didn't even know that both canvas kit and fonts are not self-hosted. I'm currently on vacation and will merge this request next week.

@openpaul
Copy link
Contributor Author

openpaul commented Sep 29, 2022

thank you for considering the merge.
Took me some time to figure out that this options exists. Do have a look at the flutter issue, the feature its not yet documented but will be once the feature is complete (as far as I understand).

I think it should not break anything, at least a quick test showed it working as intended.

Its also interesting for legal reasons, as in some countries (at least in Germany) one might be liable for fetching data from third party servers without user consent (as far as I have understood the discussion).
https://www.heise.de/news/DSGVO-Abmahnwelle-wegen-Google-Fonts-7206364.html

p.s.
great project btw. Easy to use and quite responsive.

@TomBursch
Copy link
Owner

Again thank you so much of making me aware of that, I am aware of the implications you've linked. When I'm back I'll look closely at all the outgoing traffic. It shouldn't be too hard to add roboto as a custom font and circumvent the call to Google.

And thanks for the kind words, if there is anything else you notice feel free to open issues or PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants