Skip to content

Commit

Permalink
taos: fix wake lock fail
Browse files Browse the repository at this point in the history
  • Loading branch information
@TomGiordano
TomGiordano committed Sep 12, 2011
1 parent 7e8da85 commit 52b2082
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/i2c/chips/taos.c
View file
Expand Up @@ -1002,10 +1002,10 @@ static int enable_light_and_proximity(int mask)
printk(KERN_ERR "TAOS: i2c_smbus_write_byte_data failed in ioctl prox_off\n");
return (ret);
}
wake_unlock(&taos_wake_lock);
pr_crit(TAOS_TAG "release wake lock");
return ret;
}
wake_unlock(&taos_wake_lock);
pr_crit(TAOS_TAG "release wake lock");
return ret;
}

Expand Down

4 comments on commit 52b2082

@burstlam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John-Kenney make a further fix by changing the lines of #244 &#245 as follow

static u16 prox_threshold_hi_param = 350;
static u16 prox_threshold_lo_param = 330;

values are come from the calibration program, it varies with different machines
in my case the upper value is 360 and the lower one is 340
yet they should be fine for most cases.

Proximity works fine without calibration.

@TomGiordano
Copy link
Owner Author

@TomGiordano TomGiordano commented on 52b2082 Sep 17, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LalitMaganti
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been huge issues with the proximity sensor on the Skate as well - I can tell you the details of the callibration settings that work if you like...

@TomGiordano
Copy link
Owner Author

@TomGiordano TomGiordano commented on 52b2082 Sep 17, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.