Fixed NewLoadSceneStart not being stopped in the teleporting method #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomGrobbe
reviewed
Mar 4, 2023
TomGrobbe
reviewed
Mar 4, 2023
TomGrobbe
approved these changes
Mar 4, 2023
This was causing texture loss in the city when using the teleport to waypoint option or teleport to player option (which both were using the safe teleport option).
MichaelCoding25
added a commit
to MichaelCoding25/vMenu
that referenced
this pull request
Jun 14, 2023
commit f448464 Author: Vespura <31419184+TomGrobbe@users.noreply.github.com> Date: Sat Mar 4 16:01:49 2023 +0100 Fix missing using commit 7504416 Author: Callum <46331538+QuadrupleTurbo@users.noreply.github.com> Date: Sat Mar 4 14:58:18 2023 +0000 Fixed NewLoadSceneStart not being stopped in the teleporting method (TomGrobbe#287) * Fixed NewLoadSceneStart not being stopped in the teleporting method This was causing texture loss in the city when using the teleport to waypoint option or teleport to player option (which both were using the safe teleport option). * Update CommonFunctions.cs * Reduced timeout commit d3cda86 Author: Vespura <31419184+TomGrobbe@users.noreply.github.com> Date: Sat Mar 4 15:07:24 2023 +0100 Update dependencies, add .editorconfig for basic code editor style guide, cleanup some usings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing texture loss in the city when using the teleport to waypoint option or teleport to player option (which both were using the safe teleport option).
NewLoadSceneStart not stopped
https://user-images.githubusercontent.com/46331538/222713050-8df048a0-aca8-4440-bc81-9114ea648a2b.mp4
NewLoadSceneStart stopped
https://user-images.githubusercontent.com/46331538/222713339-d07a244a-439d-4b7c-926b-247982a7aa23.mp4