Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'indent' parameter to 'put' command #373

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add 'indent' parameter to 'put' command #373

merged 4 commits into from
Nov 30, 2023

Conversation

cavus700
Copy link
Contributor

I would like to add a new command line parameter for the put-command to set the indention level for various outputs. The different parsers are already respecting the IndentOption but it is not possible to pass it via the cli.

@TomWright
Copy link
Owner

Thanks for the contribution @cavus700.

Before merging I'd like to add support for the indent flag across all commands for consistency, along with the related tests.

You're welcome to do this, but if not I expect I'll get to it in the next couple of days.

@TomWright
Copy link
Owner

I've added the option across the commands but would like to add some tests next.

@cavus700
Copy link
Contributor Author

Thank you for extending the PR :)

Sure this feature is not time critical for me but I thought it would be a nice extension. Do you need some help with the tests?

@TomWright
Copy link
Owner

I'll take all the help I can get. I'm juggling a lot at the moment

@TomWright
Copy link
Owner

Thanks for adding those tests @cavus700 that's great. Lets get this merged!

Thanks for the contribution 👍

@TomWright TomWright merged commit c017f74 into TomWright:master Nov 30, 2023
12 checks passed
@cavus700 cavus700 deleted the indention-option branch December 4, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants