Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My own fork #13

Closed
wants to merge 3 commits into from
Closed

My own fork #13

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2015

Error checking in some of the scripts and other stuff

@@ -247,7 +247,7 @@ device_bestfs()
local FS

FS="$(blkid "$1" | sed -r "s/.*TYPE=//" | tr -d '"' | tr [A-Z] [a-z])"
if [ "$FS" = "msdos" -o "$FS" = "fat" -o "$FS" = "vfat" ]; then
if [ "$FS" = "msdos" -o "$FS" = "fat" ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if "$FS" were to be "vfat", the following line (FS=vfat) would be a no-op.

@Tomas-M
Copy link
Owner

Tomas-M commented Oct 27, 2017

Sorry there are too many conflicts now, cannot merge easily

@Tomas-M Tomas-M closed this Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants