Preserve Host header and don't follow redirects #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes two changes for more correct reverse proxy behavior:
* Preserve the "Host" header set by the client, instead of deriving it from the new URL (as `fetch` does by default). This ensures that e.g. if the service issues a redirect, it will be in terms of servicename.localhost, not 127.0.0.1:7001.
* Pass `{ redirect: "manual" }` to fetch. This ensures that redirects from the service are sent back to the client, instead of the reverse proxy issuing the request to the new location itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two changes for more correct reverse proxy behavior:
Preserve the "Host" header set by the client, instead of deriving it from the new URL (as
fetchdoes by default). This ensures that e.g. if the service issues a redirect, it will be in terms of servicename.localhost, not 127.0.0.1:7001.Pass
{ redirect: "manual" }to fetch. This ensures that redirects from the service are sent back to the client, instead of the reverse proxy issuing the request to the new location itself.