Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bearer" missing? #1

Closed
goern opened this issue Apr 8, 2019 · 3 comments
Closed

"bearer" missing? #1

goern opened this issue Apr 8, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@goern
Copy link

goern commented Apr 8, 2019

Isnt the word "bearer" missing with your Authorization header?

self.session.headers.update({"Authorization": f"token {token}"})

@TomasTomecek
Copy link
Owner

Hm, you're right, while looking at Github's docs:

https://developer.github.com/v4/guides/forming-calls/#communicating-with-graphql

It's interesting that it works in the current form, maybe they support both?

Good catch, I'll change it.

@TomasTomecek TomasTomecek added the bug Something isn't working label Apr 8, 2019
@TomasTomecek TomasTomecek self-assigned this Apr 8, 2019
TomasTomecek added a commit that referenced this issue Apr 8, 2019
Fixes #1

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@goern
Copy link
Author

goern commented Apr 8, 2019

It doesnt matter for querying I guess, the v4 api seems to be very open... did you try it on private repos? or do a mutation?

@TomasTomecek
Copy link
Owner

We are using the v4 API in release-bot: https://github.com/user-cont/release-bot/blob/master/release_bot/github.py

There is a bunch of mutations and it works great. Probably the worst thing is to construct those queries. I recall that someone tried the bot on their private repo and it worked: we only had to change the way the repo is cloned since you can't clone a private repo anonymously over https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants