Issues/81 one of schema #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new interface for the OneOf schema, and adds the implements clause to the $ref class using a new Modifier, AddInterface. This changes the core from a pure uninterrupted stream to a two-step process: The first step collects Definitions and Modifiers together into a table of name -> definition, then streams the finished result out for rendering. As a result, the whole AST is collected in memory. Co-authored-by: (Jonathan) Luke Green <lukeg496@gmail.com> Co-authored-by: Hugo Pereira <hdcpereira@protonmail.com>
Co-authored-by: Hugo Pereira <hdcpereira@protonmail.com>
Co-authored-by: Hugo Pereira <hdcpereira@protonmail.com>
Tomboyo
commented
Aug 9, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/ast/AstClass.java
Show resolved
Hide resolved
Tomboyo
commented
Aug 9, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/AstGenerator.java
Show resolved
Hide resolved
Tomboyo
commented
Aug 9, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/OasSchemaToAst.java
Show resolved
Hide resolved
Tomboyo
commented
Aug 9, 2023
.../lily-compiler/src/test/java/io/github/tomboyo/lily/compiler/feature/ComposedSchemaTest.java
Outdated
Show resolved
Hide resolved
Tomboyo
commented
Aug 9, 2023
.../lily-compiler/src/test/java/io/github/tomboyo/lily/compiler/feature/ComposedSchemaTest.java
Show resolved
Hide resolved
Tomboyo
commented
Aug 9, 2023
.../lily-compiler/src/test/java/io/github/tomboyo/lily/compiler/feature/ComposedSchemaTest.java
Show resolved
Hide resolved
hdcpereira
reviewed
Aug 11, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/OasSchemaToAst.java
Show resolved
Hide resolved
hdcpereira
reviewed
Aug 11, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/OasSchemaToAst.java
Show resolved
Hide resolved
jlgre
reviewed
Aug 11, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/cg/AstClassCodeGen.java
Outdated
Show resolved
Hide resolved
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/AstGenerator.java
Show resolved
Hide resolved
Co-authored-by: (Jonathan) Luke Green <lukeg496@gmail.com> Co-authored-by: Hugo Pereira <hdcpereira@protonmail.com>
Tomboyo
force-pushed
the
issues/81-one-of-schema
branch
from
e792148
to
c620900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.