use correct escaper for insert queries #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenprough-sift
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
I tested this in my project and it works. Thank you so much for fixing, this!
Testing Notes
I created a seed file with these contents:
"long_form","contraction_form"
"do not","don't"
"can not","can't"
dbt seedsuccessfully loaded the data into Athenadbt buildsuccessfully loaded the data into Athena
owenprough-sift
added a commit
to owenprough-sift/dbt-athena
that referenced
this pull request
Nov 10, 2022
Copy/paste from: Tomme/dbt-athena#117
nicor88
added a commit
to dbt-athena/dbt-athena
that referenced
this pull request
Nov 10, 2022
Copy/paste from: Tomme/dbt-athena#117 Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com>
nicor88
added a commit
to dbt-athena/dbt-athena
that referenced
this pull request
Nov 15, 2022
* [BUGFIX] Add support for partition fields of type timestamp (#6) * fix glue partition handling (#2) * Add support for partition fields of type timestamp Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com> Co-authored-by: yusuf.mahtab <yusuf.mahtab@fundingcircle.com> * add changelog and prepare version bump * Get model owner from manifest (#9) * Get model owner from manifest * refactor into private function Co-authored-by: Justas Cernas <justas.cernas@fundingcircle.com> Co-authored-by: Justas Cernas <justas.cernas@fundingcircle.com> * chore: fix flake8 linting (#10) * Use correct escaper for `INSERT` queries (#18) Copy/paste from: Tomme/dbt-athena#117 Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com> * fix: share same boto session between every calls (#16) Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Daniel Messias <danielcmessias@gmail.com> Co-authored-by: yusuf.mahtab <yusuf.mahtab@fundingcircle.com> Co-authored-by: Justas Cernas <justas.cernas@fundingcircle.com> Co-authored-by: Jérémy Guiselin <9251353+Jrmyy@users.noreply.github.com> Co-authored-by: Owen <74567580+owenprough-sift@users.noreply.github.com>
nicor88
added a commit
to dbt-athena/dbt-athena
that referenced
this pull request
Nov 16, 2022
* [BUGFIX] Add support for partition fields of type timestamp (#6) * fix glue partition handling (#2) * Add support for partition fields of type timestamp Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com> Co-authored-by: yusuf.mahtab <yusuf.mahtab@fundingcircle.com> * add changelog and prepare version bump * Get model owner from manifest (#9) * Get model owner from manifest * refactor into private function Co-authored-by: Justas Cernas <justas.cernas@fundingcircle.com> Co-authored-by: Justas Cernas <justas.cernas@fundingcircle.com> * chore: fix flake8 linting (#10) * Use correct escaper for `INSERT` queries (#18) Copy/paste from: Tomme/dbt-athena#117 Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com> * fix: share same boto session between every calls (#16) Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Daniel Messias <danielcmessias@gmail.com> Co-authored-by: yusuf.mahtab <yusuf.mahtab@fundingcircle.com> Co-authored-by: Justas Cernas <justas.cernas@fundingcircle.com> Co-authored-by: Jérémy Guiselin <9251353+Jrmyy@users.noreply.github.com> Co-authored-by: Owen <74567580+owenprough-sift@users.noreply.github.com>
|
Merged to dbt-athena/dbt-athena, closing :) |
nicor88
added a commit
to Avinash-1394/dbt-athena
that referenced
this pull request
Jan 22, 2023
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nicor88 <6278547+nicor88@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #109
Couldn't find any contribution guide, or tests to add to - please point out if wrong, we have another contribution (bit bigger than this one) we'd like to make