Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current test phase depends on pillow #113

Closed
paskino opened this issue Mar 25, 2019 · 2 comments
Closed

current test phase depends on pillow #113

paskino opened this issue Mar 25, 2019 · 2 comments
Assignees
Labels

Comments

@paskino
Copy link
Contributor

paskino commented Mar 25, 2019

Currently the python tests require pillow. Could we save the image also as npy, so that we won't need the additional requirement?

NumPy files are basically binary array saved to file with a descriptive header, for which I've even written a small C++ reader. This means that we could write tests in C/C++ reading the npy file without problems.

@dkazanc
Copy link
Collaborator

dkazanc commented Mar 31, 2019

Makes sense. Options:

  1. Save image into a binary file and provide a reader for both Matlab and Python.
  2. Save into npy and use your C++ reader to read it from both Matlab and Python?

I'd guess 1 is the simplest?

@dkazanc
Copy link
Collaborator

dkazanc commented Jun 2, 2019

sorted with #124

@dkazanc dkazanc closed this as completed Jun 2, 2019
paskino added a commit that referenced this issue Jan 22, 2021
* added ACE as external project
* do not build ACE if USE_SYSTEM_ACE
* Add FindACE.cmake from gadgetron, added license and origin of the file
* compiles HDF5_DL_LIB if CUDA is found

partially closes #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants