-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjoint operator #1645
Adjoint operator #1645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @epapoutsellis for this work! Just a few minor comments but looks like a good addition and a good fix
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good addition of the Adjoint operator - requested by @jakobsj
Also a fix to our matrix operator adjoint
Also a fix to allocate to work with complex datatypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me! I just had a couple of questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some tiny editorial comments. No need to see the PR again after fixing.
- logging vs warnings (TomographicImaging#1769) - complexobj (TomographicImaging#1645)
Describe your changes
Added a new adjoint operator in CIL and fixed some errors with the complex matrix operator.
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Link relevant issues
Closes #1643
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.