Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QtPy abstraction layer (#144). GHA tests with PySide2 and PyQt5 #146

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

paskino
Copy link
Collaborator

@paskino paskino commented Apr 26, 2024

Builds on #144 and installs Qt bindings in GHA tests.
From @samtygier-stfc :

This switches to importing Qt classes via the qtpy abstraction layer. The library will then use which ever Qt binding you have in your environment. If you have multiple, its possible to select one using an environment variable (see https://github.com/spyder-ide/qtpy).

A small change to some mocking in a test was needed.

This passes all the tests, but has not been tested for an application that uses the library.

An application that uses eqt, will now need to add a dependency on the Qt binding that it wants to use.

Because now an app installing eqt will not have installed a Qt binding by default this is a backward incompatible change and will require a major version change.

@paskino paskino changed the title Adds pyside2 bindings to Qt to #144 Adds GHA tests to #144 Apr 26, 2024
@paskino paskino marked this pull request as draft April 26, 2024 07:37
@paskino paskino changed the title Adds GHA tests to #144 Use QtPy abstraction layer (#144). GHA tests with PySide2 and PyQt5 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable changing of Qt backend
3 participants