Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't translate on image registration panel if we have reloaded different images in the same session #86

Open
lauramurgatroyd opened this issue Jan 26, 2022 · 11 comments · Fixed by #293 · May be fixed by #247
Open

Can't translate on image registration panel if we have reloaded different images in the same session #86

lauramurgatroyd opened this issue Jan 26, 2022 · 11 comments · Fixed by #293 · May be fixed by #247
Assignees
Labels
bug Something isn't working registration This label refers to the registration process

Comments

@lauramurgatroyd
Copy link
Member

Tomorrow I will update with specific file types that aren't working for me

@lauramurgatroyd lauramurgatroyd changed the title Can't translate on image registration panel Can't translate on image registration panel if we have reloaded different images in the same session Jan 27, 2022
@lauramurgatroyd
Copy link
Member Author

This is not specific to file type.

If I open the app and load 2 images then register, it's fine.

Straight after if I reload 2 different images and then try to register it doesn't work.

@lauramurgatroyd
Copy link
Member Author

I have this when I run from #87 with vtk8.1.2 and viewer current master

@lauramurgatroyd
Copy link
Member Author

when we load new images we should run the functionality that "New session" has

@DanicaSTFC DanicaSTFC self-assigned this Nov 24, 2023
@DanicaSTFC DanicaSTFC added the bug Something isn't working label Nov 24, 2023
@DanicaSTFC DanicaSTFC added this to the Next version milestone Nov 24, 2023
@DanicaSTFC DanicaSTFC added the registration This label refers to the registration process label Nov 24, 2023
@DanicaSTFC
Copy link
Contributor

When I manually register the "Translate Z" widget does not update and it is stuck to 0. Is this the problem you mention above or something different?

@lauramurgatroyd
Copy link
Member Author

Do you mean just the widget but it allows you to move the images relative to each other?

In my case I could not move the images relative to each other at all, but this only happened if I had loaded an image/different images multiple times int he same session

@DanicaSTFC
Copy link
Contributor

Do you mean just the widget but it allows you to move the images relative to each other?

In my case I could not move the images relative to each other at all, but this only happened if I had loaded an image/different images multiple times int he same session

Yes, I mean the widget to move the images relative to each other. However I do not know if the shift in the z direction is recorded and passed to the core code correctly. I will check that and open a new issue about it.

@lauramurgatroyd
Copy link
Member Author

Did this only happen if you reloaded different images in the same session?

@DanicaSTFC
Copy link
Contributor

No, I checked it and it does it all the time for the images I tried.

@lauramurgatroyd
Copy link
Member Author

Did we conclude that you did not have a problem with translation on Z in the end?

@DanicaSTFC
Copy link
Contributor

Yes, I understood what my concern was and it is not a bug. We just need to clarify that by using the mouse one can sweep the volume in the third direction, this is not a translation. This will be addressed in issue #209

@DanicaSTFC DanicaSTFC linked a pull request May 22, 2024 that will close this issue
1 task
@DanicaSTFC
Copy link
Contributor

The problem seems to be that when we reload new data the observers no longer work

iDVC/src/idvc/dvc_interface.py

Lines 1245 to 1246 in 0fed047

self.vis_widget_reg.frame.viewer.style.AddObserver('KeyPressEvent', self.OnKeyPressEventForRegistration, 1.5) #Happens before viewer KeyPressEvent (higher priority)
self.vis_widget_reg.frame.viewer.style.AddObserver('KeyPressEvent', self.AfterKeyPressEventForRegistration, 0.5) #Happens after viewer KeyPressEvent (lower priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working registration This label refers to the registration process
Projects
Status: 🔖 To do
2 participants