Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChaCha20(&Poly1305) Support #26

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Sere-Fu
Copy link
Collaborator

@Sere-Fu Sere-Fu commented Mar 30, 2023

No description provided.

Copy link
Collaborator

@superajun-wsj superajun-wsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JNI_TRACE("ctx=%p EVP_CipherUpdate => threw error", ctx.get());
return;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少EVP_CipherFinal()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补上了

throw new InvalidAlgorithmParameterException("Aead Cipher must be initialized with params");
} else {
if (!(params instanceof IvParameterSpec)) {
throw new InvalidAlgorithmParameterException("Must be CCMParameterSpec");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCMParameterSpec ??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

@dongbeiouba dongbeiouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongbeiouba dongbeiouba merged commit af82af3 into Tongsuo-Project:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants