Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onCreateViewHolder is being spammed again #50

Closed
kcorwin opened this issue Mar 3, 2015 · 8 comments
Closed

onCreateViewHolder is being spammed again #50

kcorwin opened this issue Mar 3, 2015 · 8 comments

Comments

@kcorwin
Copy link

kcorwin commented Mar 3, 2015

I noticed this after updating to the 0.4.0 release - onCreateViewHolder gets called rapidly on scroll. Reverting to 0.2.4 fixes it.

I'm assuming this is a regression of either issue #15 or issue #13 or both.

@TonicArtos
Copy link
Owner

Thanks, it seems to be related to #15 when scrolling down.

@TonicArtos
Copy link
Owner

Actually it is a tiny bit weird that it only crops up on the first scroll over the grid's header, but I'll fix it anyway :)

@TonicArtos
Copy link
Owner

Regression was introduced in 579a591.

@TonicArtos
Copy link
Owner

Okay, so I've pushed the fix for this out in a v0.4.4-SNAPSHOT. I've decided to sit on this for a day in case any other bugs get reported in that time.

@TonicArtos
Copy link
Owner

I will close this manually when v0.4.4 is published.

@kcorwin
Copy link
Author

kcorwin commented Mar 3, 2015

This does the trick - thanks! And impressive turn-around time. :)

@TonicArtos
Copy link
Owner

Though debugging views isn't the easiest, finding the bugged code for this kind of problem is easy. Also, I think this is the last of the caching and recycle errors for view handling. In master:HEAD I have gone and cached the section data so there should be a less view binding too.

TonicArtos added a commit that referenced this issue Mar 4, 2015
- Fix regression spamming create views. Closes #50.
@TonicArtos
Copy link
Owner

...and v0.4.4 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants