Parsing string args correctly #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the code that cause commands that had quotes in them to not work as expected. Commands are no longer split just on a whitespace. If an opening quote is found the split function finds its ending quote and returns the entire chunk as one argument.
| @@ -33,6 +33,35 @@ func TestNewBuilder(t *testing.T) { | |||
| assert.Equal(t, c.IgnoredItems, b.ignoredItems) | |||
| } | |||
|
|
|||
| func TestNewBuilder_CmdWithQuotes(t *testing.T) { | |||
| c := config{ | |||
| Build: []string{ | |||
There was a problem hiding this comment.
Just to cover our cases, can we add the same cases for the Runners
There was a problem hiding this comment.
Will do. I'll make this a table test to make it easier to add some cases
Tonkpils
added a commit
that referenced
this pull request
Feb 20, 2016
Parsing string args correctly
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the code that cause commands that had quotes in them to not work as expected.
Commands are no longer split just on a whitespace. If an opening quote is found the split function
finds its ending quote and returns the entire chunk as one argument.