Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependencies): redundant uuid dep, deprecated rxjs method #836

Merged
merged 1 commit into from
May 5, 2023

Conversation

sergeyampo
Copy link
Contributor

No description provided.

@Tony133
Copy link
Owner

Tony133 commented May 5, 2023

LTGM

@Tony133 Tony133 merged commit f7c809f into Tony133:main May 5, 2023
6 checks passed
@sergeyampo
Copy link
Contributor Author

@Tony133 When will this code be released?

@Tony133
Copy link
Owner

Tony133 commented May 6, 2023

@sergeyampo If you need the package updated with the latest changes, I can create a new version. let me know

@Tony133
Copy link
Owner

Tony133 commented May 29, 2023

I have released a new version of the package 🎉

Regarding the change of the retryWhen method to the delay method, I have slipped this change to future versions of the package because currently using the delay method instead of the retryWhen method in the knexjs.utils.ts file from what I understand you have a slightly different behavior, however I will evaluate later to make this change, with the next version, I want to investigate a little better what changes between the two methods, even though they are very similar to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants