updated jshint added "unused": true #363

mschultheiss83 · 2017-08-16T13:39:31Z

fixed issues
fixed similar code: the roles.[role].died function
fixed complexity for brain.handleUnexpectedDeadCreeps by extracting functions

fixed issues fixed similar code: the `roles.[role].died` function fixed complexity for brain.handleUnexpectedDeadCreeps by extracting functions

mschultheiss83 · 2017-08-16T13:58:01Z

@TooAngel @Nevrdid @Somotaw some reviews please, i know many changes in here, but if you're using some inspection there are not sooo many,
with the JSHint Option "unused" you will find them realy fast

Nevrdid

The only thing i seen which may need a fix is call to executeEveryTick wrongly written (didn't verify but else, the method should be renamed ^^'). About returnCode, i think we need a good return policy until this we can remove all the ones you commented.

Nevrdid · 2017-08-16T14:13:22Z

src/prototype_creep_resources.js

@@ -120,7 +120,7 @@ Creep.prototype.handleExtractor = function() {
      if (this.carry[key] === 0) {
        continue;
      }
-      let returnCode = this.transfer(this.room.terminal, key);
+      returnCode = this.transfer(this.room.terminal, key);


may comment returncode here too.

Nevrdid · 2017-08-16T14:14:31Z

src/prototype_creep_routing.js

@@ -13,7 +13,7 @@ Creep.prototype.getRoute = function() {

  // Add room avoidance
  let route = [];
-  let creep = this;
+  //let creep = this;


can remove it totally

Nevrdid · 2017-08-16T14:21:22Z

src/prototype_creep_startup_tasks.js

@@ -159,7 +159,7 @@ Creep.prototype.getEnergyFromStorage = function() {

 Creep.prototype.repairStructure = function() {
  let structure = null;
-  let i = null;
+  //let i = null;


free to remove

Nevrdid · 2017-08-16T14:23:28Z

src/prototype_room_attack.js

+        creep: 2,
+        role: 'squadheal'
+      }
+    ];


are you sure about that ?

I don't think this is correct, line 24 can be removed

Nevrdid · 2017-08-16T14:24:49Z

src/prototype_room_basebuilder.js

-      };
+      //let getWalls = function(object) {
+      //  return object.structureType === STRUCTURE_WALL;
+      //};


we now use propertyfilters. can be remove so i supose

Nevrdid · 2017-08-16T14:40:43Z

src/prototype_room_routing.js

-    creep: {}
-  };
+      creep: {}
+    };


still strange for me x)

Nevrdid · 2017-08-16T14:45:22Z

src/prototype_room_wallsetter.js

@@ -43,13 +43,13 @@ Room.prototype.checkExitsAreReachable = function() {

  let exits = this.find(FIND_EXIT);
  let room = this;
-  var callbackNew = function(roomName) {
+  var callbackNew = function() {


return room.getMemoryCostMatrix() for line under ? ^^'

Nevrdid · 2017-08-16T14:45:35Z

src/prototype_room_wallsetter.js

    let costMatrix = room.getMemoryCostMatrix();
    return costMatrix;
  };
  for (let exit of exits) {
    //     console.log(exit);
-    let room = this;
+    //let room = this;


free to remove

Nevrdid · 2017-08-16T14:46:31Z

src/role_autoattackmelee.js


 roles.autoattackmelee.preMove = function(creep) {
-  //  creep.log('!!!!!!!!!!!!!!!! Autoattacking');
+  if (creep.room.exectueEveryTicks(25)) {


Well, it is correct.

We should rename the method ...

^^' didn't verify

Nevrdid · 2017-08-16T14:52:38Z

src/role_squadheal.js

-};
+//roles.squadheal.execute = function(creep) {
+//  creep.log('Execute!!!');
+//};


need tooAngel validation but pretty sure it can be totally removed. I remember i removed some call in room_my if i'm right

Hm, not sure :-)

I think we should get rid of the execute function completely. This was the old system for executing creeps, if action returns false, the main loop will execute execute, this shouldn't happen anymore.

TooAngel

I like, especially enforcing it for the future.

IMHO all old code parts can be removed instead of comments.
We have version control if we want to check.

TooAngel · 2017-08-16T17:55:38Z

src/config_brain_memory.js

@@ -111,7 +132,7 @@ brain.cleanRooms = function() {
  if (Game.time % 300 === 0) {
    for (let name in Memory.rooms) {
      // Check for reserved rooms
-      let memory = Memory.rooms[name];
+      //let memory = Memory.rooms[name];


Can be removed

TooAngel · 2017-08-16T17:56:19Z

src/prototype_creep.js

@@ -213,7 +213,7 @@ Creep.prototype.buildRoad = function() {
    return false;
  }

-  var i;
+  //var i;


Can be removed

TooAngel · 2017-08-16T17:59:32Z

src/prototype_room_attack.js

+        creep: 2,
+        role: 'squadheal'
+      }
+    ];


I don't think this is correct, line 24 can be removed

TooAngel · 2017-08-16T18:01:18Z

src/prototype_room_fight.js

@@ -1,12 +1,12 @@
-Room.prototype.getFriends = function(object) {
+Room.prototype.getFriends = function() {


^^ I don't understand that comment

TooAngel · 2017-08-16T18:03:14Z

src/role_autoattackmelee.js


 roles.autoattackmelee.preMove = function(creep) {
-  //  creep.log('!!!!!!!!!!!!!!!! Autoattacking');
+  if (creep.room.exectueEveryTicks(25)) {


Well, it is correct.

We should rename the method ...

TooAngel · 2017-08-16T18:05:50Z

src/role_squadheal.js

-};
+//roles.squadheal.execute = function(creep) {
+//  creep.log('Execute!!!');
+//};


Hm, not sure :-)

I think we should get rid of the execute function completely. This was the old system for executing creeps, if action returns false, the main loop will execute execute, this shouldn't happen anymore.

ghost · 2017-08-16T18:07:42Z

A new review, yeah.

Votes: 248/463
Coefficient: 0.535637149028
Merging in 6 days 18 hours
Age 0 days 4 hours

TooAngel · 2017-09-04T17:00:01Z

Would like to see this merged into master, mind fixing the conflicts?

mschultheiss83 · 2017-09-22T10:08:00Z

#411

updated jshint added "unused": true,

4271a23

fixed issues fixed similar code: the `roles.[role].died` function fixed complexity for brain.handleUnexpectedDeadCreeps by extracting functions

mschultheiss83 mentioned this pull request Aug 16, 2017

updated jshint added "unused": true, fixed jshint issues #362

Closed

fixed spaces

eda869f

Nevrdid reviewed Aug 16, 2017

View reviewed changes

TooAngel approved these changes Aug 16, 2017

View reviewed changes

mschultheiss83 closed this Sep 22, 2017

mschultheiss83 deleted the feature/unused-var branch September 22, 2017 10:08

mschultheiss83 restored the feature/unused-var branch September 22, 2017 10:08

mschultheiss83 deleted the feature/unused-var branch February 25, 2023 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated jshint added "unused": true #363

updated jshint added "unused": true #363

mschultheiss83 commented Aug 16, 2017

mschultheiss83 commented Aug 16, 2017

Nevrdid left a comment

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

TooAngel Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

TooAngel Aug 16, 2017

Nevrdid Aug 16, 2017

Nevrdid Aug 16, 2017

TooAngel Aug 16, 2017

TooAngel left a comment

TooAngel Aug 16, 2017

TooAngel Aug 16, 2017

TooAngel Aug 16, 2017

TooAngel Aug 16, 2017

TooAngel Aug 16, 2017

TooAngel Aug 16, 2017

ghost commented Aug 16, 2017

TooAngel commented Sep 4, 2017

mschultheiss83 commented Sep 22, 2017

		@@ -1,12 +1,12 @@
		Room.prototype.getFriends = function(object) {
		Room.prototype.getFriends = function() {

updated jshint added "unused": true #363

updated jshint added "unused": true #363

Conversation

mschultheiss83 commented Aug 16, 2017

mschultheiss83 commented Aug 16, 2017

Nevrdid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TooAngel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Aug 16, 2017

TooAngel commented Sep 4, 2017

mschultheiss83 commented Sep 22, 2017