Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add allowWall and allowFlag mechanism #696

Merged
merged 1 commit into from
Mar 15, 2023
Merged

feature: add allowWall and allowFlag mechanism #696

merged 1 commit into from
Mar 15, 2023

Conversation

XenoAmess
Copy link
Contributor

No description provided.

@XenoAmess XenoAmess force-pushed the feature/add_allowWall_and_allowFlag_mechanism branch from 60072c9 to 62d0567 Compare February 25, 2023 06:31
@mschultheiss83
Copy link
Contributor

why do you need this?

TooAngel
TooAngel reviewed Feb 25, 2023
View reviewed changes
Copy link
Owner

@TooAngel TooAngel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm fine with this. A bit more explanation in the commit or in the documentation would be nice, so that other know about it.

@XenoAmess
Copy link
Contributor Author

For building some walls on the place which I humanly think it should.

If not building such a mechanism, bot will destroy the walls you clicked.

Could be used to build some wall-arts, or for some extream defensive point that can't be found by bot.

TooAngel
TooAngel approved these changes Feb 26, 2023
View reviewed changes
Copy link
Owner

@TooAngel TooAngel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approved this now.

But please try to be a bit more detailed in the commit message and pull request description.
In a couple of weeks it's tricky to remember what this was good for.

@XenoAmess XenoAmess force-pushed the feature/add_allowWall_and_allowFlag_mechanism branch from 62d0567 to cc3e07c Compare February 27, 2023 01:43
@XenoAmess
feature: add allowWall and allowFlag mechanism
7b48b84 
For building some walls on the place which I humanly think it should.
If not building such a mechanism, bot will destroy the walls you clicked.
Could be used to build some wall-arts, or for some extreme defensive point that can't be found by bot.
@XenoAmess XenoAmess force-pushed the feature/add_allowWall_and_allowFlag_mechanism branch from cc3e07c to 7b48b84 Compare March 12, 2023 03:59
@TooAngel TooAngel merged commit 4502a44 into TooAngel:master Mar 15, 2023
@TooAngel
Copy link
Owner

This pull request was merged by worlddriven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooAngel TooAngel TooAngel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XenoAmess @mschultheiss83 @TooAngel