Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html with mobile first, responsive design #189

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Update index.html with mobile first, responsive design #189

merged 4 commits into from
Oct 10, 2020

Conversation

IanFindlay
Copy link
Contributor

These commits make the index page look better. Changes include:

  • No white background on the logo and responsive sizing

  • Media queries are massively simplified as part of mobile first design. The site should now look decent on pretty much any device and is easier to change

  • Merge_to image has alternate crops of it which load depending upon screen size. Old image looked awful on small screens and introduced horizontal scrolling to them which is never good

  • Slightly changed which colours from the colour scheme were used in order to make links look nice - i.e. a bottom border and a colour that matches the logo

  • Bigger font, that is again responsive to the screen size, and more space around things in general

  • Paler background image as I found it a little bit too dark and distracting when reading at its current opacity

@worlddrivenbot
Copy link

This pull request will be automatically merged by worlddriven in 19 day(s) and 16 hour(s).
The start date is based on the latest Commit date / Pull Request created date / (force) Push date.
The time to merge is 5 days plus 5 days for each commit.
Check the worlddriven status check or the dashboard for actual stats.

To speed up or delay the merge review the pull request:

  1. Files changed
  2. Review changes
  • Speed up: Approve
  • Delay or stop: Request changes

Copy link
Owner

@TooAngel TooAngel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

(I think for Pixel 2 411x731 (my phone) the merge_at image is too big.)

I'm not so much into UI/UX, so feel free to play around. Just some of my thoughts:

  • Keep the tech stack and dependencies simple (not necessary including something like bootstrap)
  • Maybe splitting the three phases into something like tabs, with the first dominant and the others more 'greyed' out, to show the current status and don't distract with the long term idea.


</div>
<center><h6>Trustable service landscape</h6></center>
<h4>Trustable service landscape</h4>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this one very small because I'm not so sure about that tagline.

Somehow it describes the long (long long) term idea pretty good. Right now I'm more into getting feedback about the basic auto-merge idea.
So presenting mainly the auto merger and if this is of interest continue with Phase 2 and 3.
Does that make sense?

In that context, the tagline does not fit so well.
What do you think?

So the change is fine, just wanted to give some background.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't love the tagline either. If we come up something better before this merges, which will be a while due to the pending merges prior to this that I'll need to incorporate thus resetting the timer, I'll update it; if not, I'll probably just remove it for now.

I agree with focusing on the auto-merge for now. I'd rather do one thing great that loads of things okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave some slogan ideas below - I'll just add them here as I think of them rather than a new comment every time:

Collaboration Through Automation
Driving Development

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, not yet convinced:

  • Automation supported collaboration (in yours I see the automation part too strong. Not sure if it works in English, in German, this could be a pun)
  • Driving Development would be a bit too much Drive in my opinion :-)

I thought about: When we go somehow in the 'tab' idea (for each phase a something like a tab), we could also adapt the tagline for each phase.
So Phase 1 more centered around the automated merging / collaboration
Phase 2 more a service idea tag line ...

@@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>World driven - pull request auto merge</title>
<title>World Driven - Pull Request Auto-Merge</title>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start the naming discussion here, especially because I couldn't make up my mind yet :-)

  • World Driven
  • worlddriven
  • world-driven

Any opinion, if yes, why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like worlddriven - compounds with double letters don't work for me - but could be swayed towards World-Driven I think. I'm envisaging a logo where the dash is the pull request logo and think it works quite well. It also fits in nicely with my preferred auto-merge.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K, let's do World Driven for now, also thinking that the current domain worlddriven.org fits better (otherwise it should be world-driven.org :-))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think people would forgive the lack of a hyphen in the URL. I for one wouldn't expect a project called World-Driven to be at world-driven.org. Regardless, World Driven works for me and may in fact be my first choice.

@worlddrivenbot
Copy link

Thank you for the review.
This pull request will be automatically merged by worlddriven in 1 day(s) and 0:00:35.997160 hour(s). Current votes: 170/184.

Check the worlddriven status checks or the dashboard for actual stats.

@IanFindlay
Copy link
Contributor Author

(I think for Pixel 2 411x731 (my phone) the merge_at image is too big.)

I'll have a look, should be relatively easy to tweak these things now the media queries are pared down.

  • Keep the tech stack and dependencies simple (not necessary including something like bootstrap)

Absolutely with you on that one.

  • Maybe splitting the three phases into something like tabs, with the first dominant and the others more 'greyed' out, to show the current status and don't distract with the long term idea.

I'll have to think about this one there are a lot of possible options for that sort of thing. A separate page for the long term ideas is the obvious way, could make them expandable and style them similarly to folded code to fit with the theme.

@TooAngel TooAngel mentioned this pull request Oct 8, 2020
The merge_at image forced horizontal scrolling on small screens and
looked awful as a result. This commit adds two other versions of the
image appropriately cropped to work responsively to screen size.
@TooAngel TooAngel merged commit d3fc217 into TooAngel:master Oct 10, 2020
@TooAngel
Copy link
Owner

This pull request was merged by worlddriven.

@IanFindlay IanFindlay deleted the dev/update-site branch October 13, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants