Timeout in WebSocketClient not used

[sfroeth]

Hi,

One of the constructors of WebSocketClient takes a value for a timeout, but it is actually never used. The default timeout used by SocketChannel.connect() seems to be something around two minutes if the remote host does not answer. For my use case much shorter timeouts are necessary. I fixed it for me using a thread and calling SocketChannel.close():

// method interruptibleRun():

        /*
         *  Timeout for the SocketChannel using InterruptibleChannel.close()
         *  SocketChannel.connect(...) throws AsynchronousCloseException after calling close()
         */
        if(timeout != 0) {
            new Thread(new Runnable() {

                @Override
                public void run() {
                    try {
                        Thread.sleep(timeout);
                        if(!channel.isConnected()) {
                            channel.close();
                        }
                    } catch (Exception e) {
                        // does not matter
                    }
                }
            }).start();
        }

        channel.connect( new InetSocketAddress( host, port ) );

Regards
Stefan

[Davidiusdadi]

yeah its true that the timeout is currently not used.
its because its hard to implement it in a clean and performant way. I will
however so something about it within the next weeks.

2013/5/3 sfroeth notifications@github.com

Hi,

One of the constructors of WebSocketClient takes a value for a timeout,
but it is actually never used. The default timeout used by
SocketChannel.connect() seems to be something around two minutes if the
remote host does not answer. For my use case much shorter timeouts are
necessary. I fixed it for me using a thread and calling
SocketChannel.close():

// method interruptibleRun():

    /*
     *  Timeout for the SocketChannel using InterruptibleChannel.close()
     *  SocketChannel.connect(...) throws AsynchronousCloseException after calling close()
     */
    if(timeout != 0) {
        new Thread(new Runnable() {

            @Override
            public void run() {
                try {
                    Thread.sleep(timeout);
                    if(!channel.isConnected()) {
                        channel.close();
                    }
                } catch (Exception e) {
                    // does not matter
                }
            }
        }).start();
    }

    channel.connect( new InetSocketAddress( host, port ) );

Regards
Stefan

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/177
.