Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The WebSocketClient thread never finishes #5

Closed
AlexTM opened this issue Oct 8, 2010 · 1 comment
Closed

The WebSocketClient thread never finishes #5

AlexTM opened this issue Oct 8, 2010 · 1 comment

Comments

@AlexTM
Copy link

AlexTM commented Oct 8, 2010

The thread that is started here line 96, WebSocketClient.java

public void connect() {
(new Thread(this)).start();
}

Never exits the run() function.

Calling close does disconnect the websocket and call the onClose function, however the thread just sits on the selector.select(); call.

@TooTallNate
Copy link
Owner

Make WebSocketClient#close actually end the underlying Thread and socket connection. Closed by e5e2194.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants