Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcasting a ByteBuffer #711

Closed
PhilipRoman opened this issue May 24, 2018 · 2 comments
Closed

broadcasting a ByteBuffer #711

PhilipRoman opened this issue May 24, 2018 · 2 comments

Comments

@PhilipRoman
Copy link
Collaborator

I would be very interested into an overload broadcast(ByteBuffer) for WebSocketServer like the one for byte arrays and strings. One could use ByteBuffer.array() but it is, in fact, sematically different, because variables like position and limit are not taken in account when sending. Are there any technical difficulties preventing such an overload and would there be any opportunities of optimization compared to iterating clients and sending the buffer to each?

@marci4
Copy link
Collaborator

marci4 commented May 24, 2018

Hello @PhilipRoman,

thank you very much for the idea.
Yeah, for me it was never a use case so I thought, I just to the byte array.
But I see where you are coming from!

Feel free to open a PR for this. I am more than happy to merch it!

Best regards,
marci4

@marci4
Copy link
Collaborator

marci4 commented May 27, 2018

Merged #712

Closing this issue!

@marci4 marci4 closed this as completed May 27, 2018
@marci4 marci4 added this to the Release 1.3.9 milestone May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants