Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with gradle fails #784

Closed
theAprel opened this issue Oct 12, 2018 · 2 comments
Closed

Building with gradle fails #784

theAprel opened this issue Oct 12, 2018 · 2 comments

Comments

@theAprel
Copy link
Contributor

Describe the bug
./gradle build fails immediately, with many errors similar to the following:

Java-WebSocket/src/main/java/org/java_websocket/server/WebSocketServer.java:56: error: package org.slf4j does not exist
import org.slf4j.Logger;

To Reproduce
Steps to reproduce the behavior:
Run ./gradle build

Expected behavior
Java-WebSocket builds properly

Additional context
build.gradle hasn't been updated since the slf4j dependencies were introduced to the project. I have a PR for this. These dependencies were added only to maven (pom.xml).

@theAprel theAprel mentioned this issue Oct 12, 2018
8 tasks
@theAprel
Copy link
Contributor Author

Fixed here: #785

@marci4
Copy link
Collaborator

marci4 commented Oct 12, 2018

Hello @theAprel,

thank you for your bug report and thank you for spotting this!

PR looks good, thank you again for your contribution.

Best regards,
marci4

@marci4 marci4 closed this as completed Oct 12, 2018
@marci4 marci4 added this to the Release 1.4.0 milestone Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants