Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Base64Test independent of JDK #1307

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Make Base64Test independent of JDK #1307

merged 1 commit into from
Mar 7, 2023

Conversation

anthonyvdotbe
Copy link
Contributor

@anthonyvdotbe anthonyvdotbe commented Feb 23, 2023 •
edited by marci4
Loading

Description

Base64Test fails on JDK 16+ due to https://bugs.openjdk.org/browse/JDK-8253142

Related Issue

Fixes #1306

Motivation and Context

To allow building the project with recent JDKs

How Has This Been Tested?

Running the tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@anthonyvdotbe anthonyvdotbe mentioned this pull request Mar 7, 2023
Merged
8 tasks
@PhilipRoman PhilipRoman merged commit 70092c6 into TooTallNate:master Mar 7, 2023
@anthonyvdotbe anthonyvdotbe deleted the issue-1306 branch March 7, 2023 19:47
@marci4 marci4 added the Test label Jul 20, 2023
@marci4 marci4 added this to the Release 1.5.4 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Test
Projects
None yet
Milestone
Release 1.5.4
Development

Successfully merging this pull request may close these issues.

Base64Test fails on JDK 16+
3 participants
@anthonyvdotbe @marci4 @PhilipRoman