Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol #614

Merged
merged 7 commits into from
Nov 18, 2017
Merged

Protocol #614

merged 7 commits into from
Nov 18, 2017

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Nov 18, 2017

Support for Sec-WebSocket-Protocol

Description

Implemented the possiblilty to add Sec-WebSocket-Protocol Header via constructor

Related Issue

Fixes #612
Fixes #608

Motivation and Context

https://tools.ietf.org/html/rfc6455#section-1.9

How Has This Been Tested?

Test development as well as test against Kaazing WebSocket Echo Demo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 self-assigned this Nov 18, 2017
@marci4 marci4 added this to To do in Development via automation Nov 18, 2017
@marci4 marci4 added this to the Release 1.3.7 milestone Nov 18, 2017
@marci4 marci4 moved this from To do to In progress in Development Nov 18, 2017
@marci4 marci4 merged commit 70e0ab3 into TooTallNate:master Nov 18, 2017
Development automation moved this from In progress to Done Nov 18, 2017
@marci4 marci4 removed this from Done in Development Dec 11, 2017
@marci4 marci4 deleted the protocol branch September 10, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marci4 marci4

Labels
New Feature Refactor Test
Projects
None yet
Milestone
Release 1.3.7
Development

Successfully merging this pull request may close these issues.

Test development for Sec-WebSocket-Protocol Sec-WebSocket-Protocol header not supported
1 participant
@marci4